Make prism kernels return np.nan on vertices
#108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the 3rd order kernel functions for prisms to return `np.nan` when the observation points matches any vertex of the prisms. Fixes division-by-zero error when evaluating `kernel_enu` when `radius` is zero, and makes the behaviour consistent with the other third-order kernels.
santisoler
changed the title
np.nan on vertices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the 2nd and 3rd order kernel functions for prisms to return
np.nanwhen the observation points matches any vertex of the prisms. Fixes division-by-zero error when evaluatingkernel_enuwhenradiusis zero, and makes the behavior consistent with the other third-order kernels.Relevant issues/PRs:
This is related to a bug noticed by @thibaut-kobold in SimPEG's Mattermost channel.