Fix bug in third order prism kernels #118
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the math definition of all "iij" kernels and the expected values in doctests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug related to numerical instabilities on third order kernels
kernel_iij, wherei, j in {x, y, z}. Make use of the alternative definition of the kernels. These two different definition are not mathematically equal, but their difference depends solely on two of the three coordinates, therefore when evaluating the kernels on the prism boundaries that extra term gets cancelled out. This property makes these two different definitions equivalent in the purpose of forward modelling prism fields. Add tests that catch the bug and ensure that the new implementation works as expected. Update the docstrings.Relevant issues/PRs:
The bug was reported by @AmziJeffs in simpeg/simpeg#1607