Add magnetic gradiometry forwards for prisms #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the signs in the documentation and in the implementation of each kernel. Also make the kernels to return zero on singular points (not on vertices) so when computing on lines shared with the edges are not falling in division by zero errors and the limits for those cases are well resolved.
Singular points for the grad components should be the same as the ones for the magnetic field components: interior points, edges and vertices.
Reduce repeated code by dumping the evaluation of the kernels on its own private function.
Fix minus sign applied to a list and set an atol so we can compare values close to zero.
Test if evaluation of the mag grad components on singular points return nans.
This way I quickly verified that the mathematical expressions in the docstrings match the implementations.
|
I'm quite happy with this PR. We have plenty of tests and the docstrings look good. I'll merge it. If we think about anything else we want to modify, we can do it later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add forward modelling functions for the magnetic gradiometry components due to rectangular prisms: spatial derivatives of the magnetic field components. Include third-order kernel functions that are needed to compute the derivatives of the magnetic field components. Create private function to evaluate the kernels on the vertices of the prism provided its magnetization so we can reduce the amount of repeated code in the magnetic forward modelling functions. Add tests for the new functions.
TODO: