-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using underline with a different fg color breaks it #206
Comments
Maybe instead of applying a generic reset [0m, color should apply the specific reset for the specified format. |
I will be submitting a branch 'issue_206' to resolve this issue. |
Merged
fatih
added a commit
that referenced
this issue
Oct 18, 2023
mikelorant
added a commit
to mikelorant/coloredcobra
that referenced
this issue
Apr 13, 2024
When upgrading the Color package from `v1.15.0` to `v1.16.0`, the list of available commands becomes incorrectly aligned: ```text Available Commands: completion Generate the autocompletion script for the specified shell help Help about any command test Test command for clarity ``` This was related to an [issue][1] where reset codes were not correctly set. The [fix][2], which added extra reset codes, increased the length of the string (which includes the ANSI codes) causing the amount of padding to be insufficient. This change, which upgrades the Color package to `v1.16.0`, also increass the padding to account for the additional ANSI reset codes that are now part of the string. This restores the text alignment to how it was previously displayed. Unit tests also needed to be updated to account for this change and are passing successfully. The Color package had updated its dependencies which has caused the changes in `go.mod` to impact more than itself. Fixes: ivanpirog#4 [1]: fatih/color#206 [2]: fatih/color#210 Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
daylinmorgan
pushed a commit
to daylinmorgan/coloredcobra
that referenced
this issue
May 27, 2024
When upgrading the Color package from `v1.15.0` to `v1.16.0`, the list of available commands becomes incorrectly aligned: ```text Available Commands: completion Generate the autocompletion script for the specified shell help Help about any command test Test command for clarity ``` This was related to an [issue][1] where reset codes were not correctly set. The [fix][2], which added extra reset codes, increased the length of the string (which includes the ANSI codes) causing the amount of padding to be insufficient. This change, which upgrades the Color package to `v1.16.0`, also increass the padding to account for the additional ANSI reset codes that are now part of the string. This restores the text alignment to how it was previously displayed. Unit tests also needed to be updated to account for this change and are passing successfully. The Color package had updated its dependencies which has caused the changes in `go.mod` to impact more than itself. Fixes: ivanpirog#4 [1]: fatih/color#206 [2]: fatih/color#210 Signed-off-by: Michael Lorant <michael.lorant@nine.com.au> Signed-off-by: Daylin Morgan <me@dayl.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to pretty print a markdown file. The file uses
{{ some-text }}
in it for indicating variables, im removing the{{
/}}
and underline the inner text, and i'm also making the entire line cyan. But it seems, cyan get's removed after the first occurrence of the underlined word.An example image:
The part of the code is somewhat like this
the cyan colors stops after the first underlined word, even tho consequent words to have underlines.
In case, the full code is needed, check this
The text was updated successfully, but these errors were encountered: