Add RGB API support #225
Merged
Add RGB API support #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2024
bschaatsbergen
approved these changes
Mar 24, 2024
|
Thanks for to the reviews. I want to keep this open for some time to try it out before I merge it. |
5 tasks
|
Another vote of confidence. Worked great |
|
Hey @fatih, did you have a chance to take a look at this PR? |
|
@bschaatsbergen yeap, I'll merge this soon. Hadn't time go over it. |
Signed-off-by: Fatih Arslan <ftharsln@gmail.com>
Co-authored-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new RGB API to allow to print 24-bit colors. Opening for feedback, and will probably merge it as it is. If anyone wants to try it out, check the
TestRGBtest case or the newly added README.md docs.