Add support of g:go_doc_command option (#1420)

Add support for the g:go_doc_command option. This was documented, but not implemented.

CHANGELOG.md

@@ -30,8 +30,9 @@ type foo struct{
 * `:GoImpl` output would include extra newline, and error would include
   trailing newline from shell command: `vim-go: invalid receiver: "} *}"<00>`.
   Fixed with [gh-1386]
-
 * Run `:GoMetaLinter` against the package of the open file [gh-1414].
+* The `g:go_doc_command` and `g:go_doc_options` to configure the command for
+  `:GoDoc` were documented but never referenced [gh-1420].
 
 BACKWARDS INCOMPATIBILITIES:
 

autoload/go/doc.vim

@@ -5,11 +5,7 @@
 let s:buf_nr = -1
 
 if !exists("g:go_doc_command")
-  let g:go_doc_command = "godoc"
-endif
-
-if !exists("g:go_doc_options")
-  let g:go_doc_options = ""
+  let g:go_doc_command = ["godoc"]
 endif
 
 function! go#doc#OpenBrowser(...) abort
@@ -60,12 +56,11 @@ endfunction
 function! go#doc#Open(newmode, mode, ...) abort
   " With argument: run "godoc [arg]".
   if len(a:000)
-    let bin_path = go#path#CheckBinPath('godoc')
-    if empty(bin_path)
+    if empty(go#path#CheckBinPath(g:go_doc_command[0]))
       return
     endif
 
-    let command = printf("%s %s", go#util#Shellescape(bin_path), join(a:000, ' '))
+    let command = printf("%s %s", go#util#Shelljoin(g:go_doc_command), join(a:000, ' '))
     let out = go#util#System(command)
   " Without argument: run gogetdoc on cursor position.
   else

doc/vim-go.txt

@@ -1190,17 +1190,11 @@ mappings of |:GoDef|. By default it's disabled. >
 <
                                                           *'g:go_doc_command'*
 
-Use this option to define which tool is used to godoc. By default `godoc` is
-used >
-
-  let g:go_doc_command = "godoc"
-<
-                                                          *'g:go_doc_options'*
-
-Use this option to add additional options to the |'g:go_doc_command'|. Default
-is empty. >
+Command to use for |:GoDoc|; only used when invoked with a package name. The
+`gogetdoc` command is always used when |:GoDoc| is used on the identifier
+under the cursor (i.e. without argument or from |K|). >
 
-  let g:go_doc_options = ''
+  let g:go_doc_command = ["godoc"]
 
 <                                                            *'g:go_bin_path'*