quickfix list clobbered on save

[nyarly]

Behavior

Having just updated vim-go, I've noticed that when I save codefiles, my quickfix window closes and the quickfix list is emptied. When correcting e.g. compile errors, this is irritating because

Steps to reproduce:

Please create a reproducible case of your problem. If this step is
not provided, the issue will be closed

Re produce it with a minimal vimrc with all plugins disabled and
only vim-go enabled:

1. open a Go project
2. :make
3. :cw
4. < quickfix window opens with errors >
5. :update
   6 < quickfix window closes, :cw won't reopen >

Configuration

Add here your current configuration and additional information that might be
useful, such as:

This is vim-go 76cd99d, under Neovim 0.1.7, and Go 1.7.4.

[ef2k]

I had the same issue and had to roll back to go-vim v1.12 (26362e4). Now the quickfix window is being displayed with build errors again.

[josephholsten]

Looks like this was introduced by e4e992a

Fortunately, it documents a workaround:

    let g:go_list_type = "locationlist"

[josephholsten]

I think https://stackoverflow.com/questions/20933836/what-is-the-difference-between-location-list-and-quickfix-list-in-vim sums up why locationlist is more appropriate anyway. TL;DR:

More generally: The quickfix list is best when your search or compile involves multiple files, the location list best when only a single file is involved. – Trebor Rude Aug 29 '14 at 17:40

[josephholsten]

@fatih can we revert e4e992a in light of the above?

[fatih]

Not sure how to fix it. Quickfix is global. So is Locationlist as well. What if you use locationlist for both save and format as well? In that case this will still happen.

This can be fixed by disabling the following line in ftm.vim

  " this closes the window if there are no errors or it opens
  " it if there is any
  call go#list#Window(l:listtype, len(a:errors))

luckily we have a new setting that prevents autoclosing it. So if you add the following you should be good to go:

let g:go_list_autoclose = 0

But I need to look more detaily for this. Let me know what happens if you add this setting and how it works for you (didn't tested it)

[hori-ryota]

How about g:go_list_type_for_autosave ?

I need to keep quickfix when execute command like GoErrCheck and GoMetalinter. But now, list is Overwritten and deleted by autosaving.

So, I want to use quickfix when execute command and use locationlist when autosave.

[fatih]

This is fixed now (please pull master) and now it won't close it anymore, unless it's the list created by :GoFmt itself (or autosave). Thanks for the feedback again.