let g:go_auto_type_info = 1 causes buffer slowdown and garbage characters

[SophisticaSean]

Behavior

When go_auto_type_info is enabled, vim will hang for a bit while figuring out the types automatically. This causes control commands to be shoved into the buffer.

Steps to reproduce:

1. Get vim-go up and running.
2. Open a .go file with a decent amount of code in it.
3. Cursor over any variable and start moving your cursor around with movement keys.
   You may have to let it sit for 800ms by default for auto_type_info to try and update.
4. You'll see movement keys inserted into the buffer when vim tries to figure out what the time of the var you were looking at was.

Disabling go_auto_type_info fixes this issue.

Configuration

• .vimrc:

execute pathogen#infect()
syntax on
let g:go_auto_type_info = 1 
set updatetime=10

• vim version: VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Oct 4 2017 09:34:57) MacOS X (unix) version Included patches: 1-1171 Compiled by Homebrew
• vim-go version: latest as of Oct 3rd (git hash: 96995056cbe744119ebd53e31068e713fa08db61)
• go version: go version go1.9 darwin/amd64

[arp242]

Well, with an updatetime of 10 you'll calling an external command quite often, so it's not unexpected that this is slow ;-)

It could be improved with async probably.

[SophisticaSean]

Haha true. The updatetime of 10 was just to highlight the problem more easily, I was still having the issue without the updatetime portion.

…

On Thu, Oct 5, 2017 at 1:26 PM, Martin Tournoij ***@***.***> wrote: Well, with an updatetime of 10 you'll calling an external command quite often, so it's not unexpected that this is slow ;-) It could be improved with async probably. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1496 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB9sAademFFtrh4IxJn2AOZIom7_fvNlks5spS1hgaJpZM4PvkNJ> .

[bhcleek]

@SophisticaSean I've seen similar things for a while, and have been trying to track down the exact cause. You can help me track down the root cause by letting me know:

1. Have you tried using guru instead of gocode by setting g:go_info_mode = 'guru'? Do you see the same behavior?
2. When using gocode, is it possible that you have go files loaded into multiple instance of vim?
3. When using gocode, does it make any difference if you wait for the first request to complete? (i.e. do you see any difference in responsiveness when gocode is warmed up?)

[SophisticaSean]

1. Guru did not work for me, it complained that it wasn't in a valid GOPATH (which it was). 2. Nope. Just one instance of vim. 3. Even after gocode warming up (hours of vim-go usage) the problem persists.

…

On Thu, Oct 5, 2017 at 3:22 PM, Billie Cleek ***@***.***> wrote: @SophisticaSean <https://github.com/sophisticasean> I've seen similar things for a while, and have been trying to track down the exact cause. You can help me track down the root cause by letting me know: 1. Have you tried using guru instead of gocode by setting g:go_info_mode = 'guru'? Do you see the same behavior? 2. When using gocode, is it possible that you have go files loaded into multiple instance of vim? 3. When using gocode, does it make any difference if you wait for the first request to complete? (i.e. do you see any difference in responsiveness when gocode is warmed up?) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1496 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB9sAVnmBtB8XOuMfTSDOcRwZB7CKxt-ks5spUidgaJpZM4PvkNJ> .

[bhcleek]

You might try getting guru working for you. On my machine I still see some delays, but not long periods where vim is unresponsive when I use guru instead of gocode for the info mode when let g:auto_type_info = 1.

[bhcleek]

With a series of recent merges (#1713, #1697, #1671), I no longer see garbage characters. @SophisticaSean Can you give the latest master a try and see if the problem is resolved for you, too?

[cherrot]

@bhcleek It is fixed for me. Thank you!

[cherrot]

UPDATE: It seems that the issue still remains (on my OSX with vim 8.0 and linux with vim 7.4), but not so often as previous. I can just ignore it when it appears once or twice.

I have set:

let g:go_auto_type_info = 1
let g:go_auto_sameids = 1

and left g:go_updatetime in its default (which is 800 I believe), FYI

[bhcleek]

There's not much we can do about it occuring vim 7.4, though it should be less of a problem than it was before on vim 7.4.

And it may still occur when your GOPATH is large and you open a file in a package that hasn't had any of its files opened in the vim session yet.

Having said that, are you still seeing it on vim 8.0 more often than when a file for a package is opened the first time in a vim session? Are you using gocode or guru for g:go_info_mode?

[cherrot]

@bhcleek Yes. On my vim 8.0, I'm seeing it only when a file for a package is opened the first time in the vim session.
And when it occurs, the garbage characters blink for 1 second and then disappears. So it is not a big problem for me now.

I'm using gocode for g:go_info_mode, which is the default.

[bhcleek]

Thank you for confirming @cherrot. I don't see a good solution yet for solving that particular use case. I'll keep my eye on it, though, and will try to resolve it if I can.