-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:GoImpl completion seems to break after an error #1554
Comments
This is my first time trying to user
if I call it and hit |
You shouldn't add quotes @deltaskelta; this should work:
The quotes are in the help because It's unrelated to this issue, but we should perhaps consider removing quotes for easier usage. |
actually I still get the error when I do that which is what led me to put the quotes there in the first place. I can open an issue if you think this is still unrelated though...I am not too familiar with the internals of how its being called |
Yes please @deltaskelta; then we also have all information about your Vim version etc. The command as such works fine for me, it's just the tab-completion that occasionally breaks for me. |
Fixes #1554 The problem is that `:GoImpl somethingInvalid` would set `v:shell_error`, and on the next `:GoImpl <Tab>` the `go#util#env()` call in `s:root_dirs()` would use the cache, so the `v:shell_error` is "stuck". Fix it by not checking this here; `go#util#env()` already shows an error so that should be fine. Long-term fix is to use `go#util#Exec()` everywhere which returns `v:shell_error` instead of relying on a global value. While I'm here also add a basic test and use `Exec()` in a few places.
(While editing
middleware/auditMiddleware/audit_test.go
; I'll investigate later).The text was updated successfully, but these errors were encountered: