Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakpoints are kept on the same line when lines are added removed #1688

Closed
arp242 opened this issue Feb 27, 2018 · 0 comments · Fixed by #2126
Closed

Breakpoints are kept on the same line when lines are added removed #1688

arp242 opened this issue Feb 27, 2018 · 0 comments · Fixed by #2126
Labels
bug debugger

Comments

@arp242
Copy link
Contributor

arp242 commented Feb 27, 2018

This causes issues after running :GoDebugRestart, as it will now be on an unexpected line.
@arp242 arp242 mentioned this issue Mar 5, 2018
Closed
arp242 added a commit that referenced this issue Mar 21, 2018
@arp242
Use signs to keep track of breakpoints
edbc1d8 
Fixes #1688

Signs already get updated correct when adding/removing lines, so use
information from `:sign place` instead of keeping track of our own list
of breakpoints. This also makes sure that what the user sees always
matches with that Vim/Delve thinks should happen.

TODO: needs some more testing. I saw an error or two I didn't have
before.
@arp242 arp242 self-assigned this Mar 21, 2018
@arp242 arp242 removed their assignment Sep 3, 2018
bhcleek pushed a commit to bhcleek/vim-go that referenced this issue Jan 13, 2019
@arp242 @bhcleek
Use signs to keep track of breakpoints
2cb52f0 
Fixes fatih#1688

Signs already get updated correct when adding/removing lines, so use
information from `:sign place` instead of keeping track of our own list
of breakpoints. This also makes sure that what the user sees always
matches with that Vim/Delve thinks should happen.

TODO: needs some more testing. I saw an error or two I didn't have
before.
@bhcleek bhcleek mentioned this issue Jan 13, 2019
Merged
bhcleek pushed a commit to bhcleek/vim-go that referenced this issue Jan 13, 2019
@arp242 @bhcleek
Use signs to keep track of breakpoints
9a8685d 
Fixes fatih#1688

Signs already get updated correct when adding/removing lines, so use
information from `:sign place` instead of keeping track of our own list
of breakpoints. This also makes sure that what the user sees always
matches with that Vim/Delve thinks should happen.

TODO: needs some more testing. I saw an error or two I didn't have
before.
bhcleek pushed a commit to bhcleek/vim-go that referenced this issue Jan 13, 2019
@arp242 @bhcleek
Use signs to keep track of breakpoints
8ee1c84 
Fixes fatih#1688

Signs already get updated correct when adding/removing lines, so use
information from `:sign place` instead of keeping track of our own list
of breakpoints. This also makes sure that what the user sees always
matches with that Vim/Delve thinks should happen.

TODO: needs some more testing. I saw an error or two I didn't have
before.
bhcleek pushed a commit to bhcleek/vim-go that referenced this issue Jan 13, 2019
@arp242 @bhcleek
Use signs to keep track of breakpoints
3ffc8e1 
Signs already get updated correct when adding/removing lines, so use
information from `:sign place` instead of keeping track of our own list
of breakpoints. This also makes sure that what the user sees always
matches with that Vim/Delve thinks should happen.

Stop removing breakpoints when debugging stops.

Fixes fatih#1688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug debugger
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use signs to keep track of breakpoints bhcleek/vim-go
1 participant
@arp242