goreturns configuration

[tobstarr]

I am struggling setting up vim-go with goreturns https://github.com/sqs/goreturns. What I tried is this:

    let g:go_fmt_command = 'goreturns'
    let g:go_fmt_options = '-w'

but it seems it always ignores the -w flag (and just prints the output to stdout). Any tips on that?

Thanx!

[sqs]

@tobstarr and I talked a bit about this on Twitter: https://twitter.com/tobstarr/status/522655779518939136. It seems like goreturns is working by itself but not in vim-go. I don't use vim, but if anyone can determine if there's something I need to fix in goreturns, please let me know and I will make a fix asap.

[fatih]

Due to nature of Vim, before I do a formatting I'm creating a temporary file and doing the formatting on it. Now this temporary file is created in a the systems temp dir. Both gofmt and goimports are successful executing them, however goreturns fails. Here is a basic example:

~ ❯ gofmt /var/folders/mc/hxkh39y93dn__458mq8xrbcm0000gn/T/vKrskW5/4
package main

import "errors"

func main() {
    F()
}

func F() (string, int, error) {
    return errors.New("foo")
}
~ ❯ goimports /var/folders/mc/hxkh39y93dn__458mq8xrbcm0000gn/T/vKrskW5/4
package main

import "errors"

func main() {
    F()
}

func F() (string, int, error) {
    return errors.New("foo")
}
~ ❯ goreturns /var/folders/mc/hxkh39y93dn__458mq8xrbcm0000gn/T/vKrskW5/4
no buildable Go source files in /var/folders/mc/hxkh39y93dn__458mq8xrbcm0000gn/T/vKrskW5

Another thing is (which I think should be changed). goreturns outputs an error message together with the corrected message. Again nor gofmt nor goimports is doing it. This is important because the output should be machine readable. If there is an error (in the case below) it should exit with non zero code instead of zero, and it only should output the error.:

demo ❯ gofmt demo.go
package main

import "errors"

func main() {
    F()
}

func F() (string, int, error) {
    return errors.New("foo")
}
demo ❯ goimports demo.go
package main

import "errors"

func main() {
    F()
}

func F() (string, int, error) {
    return errors.New("foo")
}
demo ❯ goreturns demo.go
demo.go:10:2: wrong number of return values (want 3, got 1)
package main

import "errors"

func main() {
    F()
}

func F() (string, int, error) {
    return "", 0, errors.New("foo")
}

[sqs]

Ah, got it. I will eliminate the error output.

As for the temp file, goreturns needs the file to be in the existing dir because it builds and type checks the files, unlike gofmt/goimports which just parse it. Is it possible to eliminate the usage of a temp file?

Thanks for looking into this.

[fatih]

@sqs that's unfortunately not possible. Because the undo history in Vim break when I don't use the temp file. So maybe you can do something that goreturns can be executed in that folder. On my side when I change the behavior it will just break the plugin.