Error when running Fmt:

[beefsack]

I'm incredibly impressed with the plugin, looking to switch to this full time for my Go development!

Have come across one issue, but I'm having a bit of trouble getting some troubleshooting information about it. Running Fmt is returning an error, but I can't seem to figure out what that error or the return code of goimports is.

My test file:

package test

import (
    "fmt"
)

func main() {
    fmt.Println("This is a test.")
}

When running Fmt:

:Fmt
  1 package test
  2
  3 import (
  4     "fmt"
  5 )
  6
  7 func main() {
  8     fmt.Println("This is a test.")
  9 }
Gofmt returned error

My Go version:

➜  .vim-go  go version
go version go1.2 linux/amd64

Checking to see what the Fmt command delegates to:

:Let g:co_fmt_command
g:go_fmt_command       goimports

Running goimports manually seems to work:

➜  .vim-go  ~/.vim-go/goimports $GOPATH/src/test.go 
package test

import (
    "fmt"
)

func main() {
    fmt.Println("This is a test.")
}
➜  .vim-go  echo $?
0

I'm happy to keep debugging here locally as I'm assuming this will be very tricky to reproduce. Do you have any advice as to where I would start looking to get some more valuable debugging information?

[fatih]

That's really tricky, however the Gofmt returned error should only be echoed if there is an error. I've now pushed possible fix for that, can you pleas try it?

[beefsack]

Hi @fatih, I've pulled and it's still outputting the original file in the console and doesn't seem to be formatting. This is what I'm seeing when writing to the file and when calling Fmt manually:

:w
  1 package test
  2
  3 import (
  4     "fmt"
  5 )
  6
  7 func main() {
  8         fmt.Println("This is a test.")
"test.go" 9L, 82C written
Press ENTER or type command to continue

:Fmt
  1 package test
  2
  3 import (
  4     "fmt"
  5 )
  6
  7 func main() {
  8         fmt.Println("This is a test.")
  9 }
Press ENTER or type command to continue

Seems goimports is working from a terminal though (it fixed indenting on the fmt.Println line):

➜  vim-go git:(master) ~/.vim-go/goimports $GOPATH/src/test.go
package test

import (
    "fmt"
)

func main() {
    fmt.Println("This is a test.")
}
➜  .vim-go  echo $?
0

If it helps, I'm using The Ulimate vimrc, and my extra plugins are:

• YouCompleteMe
• vim-gitgutter
• vim-go
• vim-puppet

My custom config is:

set guifont=Source\ Code\ Pro\ Light\ 10
set cc=80
set nu
set autoindent
set noexpandtab
set tabstop=4
set shiftwidth=4
set cursorline

I'm having a play around with ftplugin/go/fmt.vim to see if I can figure out something on this end.

[beefsack]

Upon further investigation, it seems goimports isn't in PATH. When I output the out variable I'm getting:

zsh:1: command not found: goimports^@

I'm using zsh instead of bash or bourne shell but I don't think that should cause an issue, I'll try to locate where ~/.vim-go is meant to be added to PATH.

[fatih]

@beefsack can you provide more information. What is your operating system? You are sure you are not using any other plugins that might conflict with it?

Btw I've just pushed a fix. There was a problem where it fallback to goimports even if there is no binary available. Can you pull and try again?

[beefsack]

The following seems to fix the issue, but it means adding ~/.vim-go to path:

➜  .vim-go  export PATH=$HOME/.vim-go:$PATH
➜  .vim-go  gvim $GOPATH/src/test

Changing the system call to include the path works too, but that would break gofmt calls so it's not much of a solution:

let out = system(g:go_bin_path . g:go_fmt_command . " " . l:tmpname)

[beefsack]

@fatih, your last commit seems to have fixed it, thanks! 👍