Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open quickfix with a smaller height if the number of items are less than 10 #592

Closed
fatih opened this issue Nov 4, 2015 · 0 comments · Fixed by #602
Closed

Open quickfix with a smaller height if the number of items are less than 10 #592

fatih opened this issue Nov 4, 2015 · 0 comments · Fixed by #602
Labels
improvement

Comments

@fatih
Copy link
Owner

fatih commented Nov 4, 2015

Right now we are opening the default, which is 10 height lines. But sometimes we only have one or two items. This can be configured with copen itemnumber.
fatih added a commit that referenced this issue Nov 15, 2015
@fatih
util: add auto quickfix window height for errors [GH-592]
f0897c8 
Right now we are just calling `cwindow` without any arguments. By
default Vim opens a view with an height of 10. But this doesn't look
good if you have only on error. It also takes display estate for small
screens.

This PR introduces a new feature, which automatically resizes the
quickfix error for the number of errors. However to prevent consuming
all the view, it's capped at 10 lines (the default Vim value).

We also have a new setting, `g:go_quickfix_height` which let us to give
an explicit window height. If set, automatic resize is enabled and the
height will be always the value of `g:go_quickfix_height`.

Closes #592
@fatih fatih mentioned this issue Nov 15, 2015
Merged
fatih added a commit that referenced this issue Nov 15, 2015
@fatih
util: add auto quickfix window height for errors [GH-592]
1fe325f 
Right now we are just calling `cwindow` without any arguments. By
default Vim opens a view with an height of 10. But this doesn't look
good if you have only one single error. It also takes display estate for
small screens.

This PR introduces a new feature, which automatically resizes the
quickfix error for the number of errors. However to prevent consuming
all the view, it's capped at 10 lines (the default Vim value).

We also have a new setting, `g:go_quickfix_height` which let us to give
an explicit window height. If set, automatic resize is enabled and the
height will be always the value of `g:go_quickfix_height`.

Closes #592
fatih added a commit that referenced this issue Nov 15, 2015
@fatih
util: add auto quickfix window height for errors [GH-592]
d5a1dff 
Right now we are just calling `cwindow` without any arguments. By
default Vim opens a view with an height of 10. But this doesn't look
good if you have only one single error. It also takes display estate for
small screens.

This PR introduces a new feature, which automatically resizes the
quickfix error for the number of errors. However to prevent consuming
all the view, it's capped at 10 lines (the default Vim value).

We also have a new setting, `g:go_quickfix_height` which let us to give
an explicit window height. If set, automatic resize is enabled and the
height will be always the value of `g:go_quickfix_height`.

Closes #592
fatih added a commit that referenced this issue Nov 16, 2015
@fatih
Merge pull request #602 from fatih/auto-height-quickfix
6384e3a 
util: add auto quickfix window height for errors [GH-592]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util: add auto quickfix window height for errors [GH-592] fatih/vim-go
1 participant
@fatih