GoTestCompile not always deleting created test-binary with Neovim #907

Limdi · 2016-06-18T10:35:25Z

Hi,
#879 said GoTestCompile removes its created test-binaries which works fine working on go-files in the same directory, I'd love to see this removing of the test-binary incase it got created in another directory too.

Actual behavior

➜  pkg git:(master) ✗ ls storage 
github  github.go  gitlab.go  storage.go  storage_test.go
➜  pkg git:(master) ✗ nvim storage/storage.go
# Running in neovim GoTestCompile
➜  pkg git:(master) ✗ ls storage 
github  github.go  gitlab.go  storage.go  storage_test.go  vim-go-test-compile

For me it reproduces nicely for other directories too

➜  pkg git:(master) ✗ find . | grep vim-go-test     
./storage/vim-go-test-compile
./mirror/project/vim-go-test-compile
./mirror/vim-go-test-compile

Expected behavior

➜  pkg git:(master) ✗ ls storage 
github  github.go  gitlab.go  storage.go  storage_test.go
➜  pkg git:(master) ✗ vim storage/storage.go
# Running in vim :GoTestCompile
➜  pkg git:(master) ✗ ls storage
github  github.go  gitlab.go  storage.go  storage_test.go

Configuration

Add here your current configuration and additional information that might be
useful, such as:

vimrc you used to reproduce
vim version:

NVIM 0.1.4
Build type: RelWithDebInfo
Compilation: /usr/bin/cc -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -Wconversion -O2 -g -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -D_GNU_SOURCE -I/build/neovim/src/build/config -I/build/neovim/src/neovim-0.1.4/src -I/usr/include -I/usr/include -I/usr/include/luajit-2.0 -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/build/neovim/src/build/src/nvim/auto -I/build/neovim/src/build/include

vim-go version: latest updated with :PlugUpdate

523d5a435d490c8c5ea3d8ed0ecac453e2f33f93

go version

go version go1.6.2 linux/amd64

The text was updated successfully, but these errors were encountered:

nightlyone · 2016-06-18T12:15:04Z

I can reproduce this too:

Linux (Ubuntu 16.04, codename Xenial) using go 1.6.2 too.
Vim: VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Apr 08 2016 11:38:28)

Note:
A simple workaround for me was to use /dev/null (or NUL on windows) instead of "vim-compile-test" as the compiler target at https://github.com/fatih/vim-go/blob/master/autoload/go/cmd.vim#L194 in order to discard compiler result.

fatih · 2016-06-22T22:43:33Z

Thanks @Limdi for the report. I'm looking into it.

@nightlyone unfortunately /dev/null/ is not supported by the go tool. We have the same problem for go build as well. I know the problem for this issue. I have a fixed version for Vim already, testing it now for NeoVim.

Closes #907

fatih · 2016-06-22T22:50:53Z

Thanks for the feedback. This issue is now fixed both for Vim and NeoVim. Please pull the latest HEAD of the master branch. Thanks.

Limdi · 2016-06-23T15:34:17Z

Wonderfull, thanks you fatih!

7AC · 2017-01-12T22:57:45Z

I'm still having this issue with vim 8.0, vim-go v1.11 installed via Vundle and this config which I basically copied from the tutorial:

function! s:build_go_files()
  let l:file = expand('%')
  if l:file =~# '^\f\+_test\.go$'
    call go#cmd#Test(0, 1)
  elseif l:file =~# '^\f\+\.go$'
    call go#cmd#Build(0)
  endif
endfunction
au BufWritePost *.go :call <SID>build_go_files()

I verified that my version has 1457e6e.

oryband · 2017-01-22T16:10:10Z

Still happenning to me as well.

rafael84 · 2017-05-29T20:25:54Z

I'm using vim 8.0.95 and vim-go 1.12. The issue is still happening.

rafael84 · 2017-05-29T20:44:37Z

So I think the problem only happens when the current working directory is not the base directory of the test file.

I can easily reproduce the problem by running the following commands:

% tree
.
└── mypkg
    └── my_test.go

1 directory, 1 file


% cat mypkg/my_test.go
package mypkg

import "testing"

func TestMy(t *testing.T) {

}


% vim mypkg/my_test.go +GoTestCompile +'sleep 1' +qall


% tree
.
└── mypkg
    ├── my_test.go
    └── vim-go-test-compile

1 directory, 2 files

However, check what happens when the current directory is mypkg:

% tree
.
└── mypkg
    └── my_test.go

1 directory, 1 file


% cd mypkg; vim my_test.go +GoTestCompile +'sleep 1' +qall; cd ..


% tree
.
└── mypkg
    └── my_test.go

1 directory, 1 file

This change improves the way we compile a Go test. Previously we would build a test binary to catch any build errors. A callback was then responsible to delete the test binary after showing build errors (if there were any). This could be racy though, because if the tests lasts long and we quit early, the callback to clean the binary file would never run. So we would end up with artifacts in our working directory. To fix the issue we're going to tell to the `go` tool to run a specific, unique function. We're passing a unique identifier as a function name (which is a randomly generated). This will cause the go tool to build the test file and then try to run the test function. Because there is no such test function, it'll silently quit with zero exit status. As a side effect it'll compile the test file, so we're able to catch any build errors (if any) fixes #907

This change improves the way we compile a Go test. Previously we would build a test binary to catch any build errors. A callback was then responsible to delete the test binary after showing build errors (if there were any). This could be racy though, because if the tests lasts long and we quit early, the callback to clean the binary file would never run. So we would end up with artifacts in our working directory. To fix the issue we're going to tell to the `go` tool to run a specific, unique function. We're passing a unique identifier as a function name (which is a randomly generated), i.e: ``` go test -run "F97CC94D-4414-41CF-A185-A077F645DF24" testing: warning: no tests to run PASS ok demo 0.006s ``` This will cause the go tool to build the test file and then try to run the test function. Because there is no such test function, it'll silently quit with zero exit status. As a side effect it'll compile the test file, so we're able to catch any build errors (if any) fixes #907

fatih · 2017-06-02T23:36:20Z

@rafael84 please pull the latest master. We don't produce a test file anymore.

rafael84 · 2017-06-03T02:00:40Z

Awesome, thanks fatih.

fatih added a commit that referenced this issue Jun 22, 2016

cmd: fix :GoTestCompile leaving behind artifacts

1457e6e

Closes #907

fatih mentioned this issue Jun 22, 2016

cmd: fix :GoTestCompile leaving behind artifacts #909

Merged

fatih closed this as completed in #909 Jun 22, 2016

fatih mentioned this issue Jun 2, 2017

test.vim: more efficient compiling of test files #1317

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GoTestCompile not always deleting created test-binary with Neovim #907

GoTestCompile not always deleting created test-binary with Neovim #907

Limdi commented Jun 18, 2016 •

edited

Loading

nightlyone commented Jun 18, 2016

fatih commented Jun 22, 2016

fatih commented Jun 22, 2016

Limdi commented Jun 23, 2016

7AC commented Jan 12, 2017 •

edited

Loading

oryband commented Jan 22, 2017

rafael84 commented May 29, 2017

rafael84 commented May 29, 2017

fatih commented Jun 2, 2017

rafael84 commented Jun 3, 2017

GoTestCompile not always deleting created test-binary with Neovim #907

GoTestCompile not always deleting created test-binary with Neovim #907

Comments

Limdi commented Jun 18, 2016 • edited Loading

Actual behavior

Expected behavior

Configuration

nightlyone commented Jun 18, 2016

fatih commented Jun 22, 2016

fatih commented Jun 22, 2016

Limdi commented Jun 23, 2016

7AC commented Jan 12, 2017 • edited Loading

oryband commented Jan 22, 2017

rafael84 commented May 29, 2017

rafael84 commented May 29, 2017

fatih commented Jun 2, 2017

rafael84 commented Jun 3, 2017

Limdi commented Jun 18, 2016 •

edited

Loading

7AC commented Jan 12, 2017 •

edited

Loading