Added ability to keep the quickfix/location list window open #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccessful operations instead of autoclosing
fatih
reviewed
Jul 21, 2017
| else | ||
| cclose | ||
| let autoclose_window = get(g:, 'go_list_autoclose', 1) | ||
| if autoclose_window |
There was a problem hiding this comment.
I think this should work as well:
if get(g:, 'go_list_autoclose', 1)
...
endifno need to create the intermediate autoclose_window variable :)
fatih
reviewed
Jul 21, 2017
| Specifies whether the quickfix/location list should be closed automatically | ||
| in the absence of errors. The default value is 1. | ||
| If you prefer to keep a long running error window open, you can disable | ||
| this by setting the value to 0. |
There was a problem hiding this comment.
I think people using Vim already know that setting to 0 means disabling. So the whole text should be actually just like the others in the form of:
Specifies whether the quickfix/location list should be closed automatically in
the absence of errors. If you prefer to keep a long running error window open,
you can disable this by using this setting. By default it's enabled.
|
Thanks @seanpile 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a workflow where I prefer to keep the quickfix/location window open during development. vim-go likes to automatically close this window on successful operations (i.e., GoFmt, GoBuild, etc...).
This change adds a configuration property to prevent this from happening. By default, the window automatically closes (current behaviour). Users can specify 0 to allow the window to remain open. Tested with a few of the basic operations, but let me know if you suspect any issues might arise.