Show correct message when editing a new file #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing a new file: vim newfile.go Vim would show the results of the `:0r` command on startup: "~/.vim/pack/plugins/start/vim-go/templates/hello_world.go" 7L, 67C Instead of the default: "newfile2.go" [New File] This corrects that by adding running the `:0r` command with `silent`. This would only occur if `go#tool#PackageName()` returns `-1`; the correct message was already shown when a package is found. There was an `echon` with a comment about removing the `[New File]` message, but this seems like the wrong behaviour to me. Either way, it didn't work; maybe the behaviour of `echon` subtly changed? Fixes #1347
|
Thanks again @Carpetsmoker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing a new file:
Vim would show the results of the
:0rcommand on startup:Instead of the default:
This corrects that by adding running the
:0rcommand withsilent.This would only occur if
go#tool#PackageName()returns-1; the correctmessage was already shown when a package is found.
There was an
echonwith a comment about removing the[New File]message, butthis seems like the wrong behaviour to me. Either way, it didn't work; maybe the
behaviour of
echonsubtly changed?Fixes #1347