Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to fails of GoMetalinter result filepath in subdir. resolve #1413 #1414

Merged
merged 2 commits into from
Sep 6, 2017
Merged

Fix to fails of GoMetalinter result filepath in subdir. resolve #1413 #1414

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5271d0
Fix to fails of GoMetalinter result filepath in subdir. resolve #1413
Aug 18, 2017
117c334
update comment
Aug 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion autoload/go/lint.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ function! go#lint#Gometa(autosave, ...) abort

let meta_command = join(cmd, " ")

let out = go#tool#ExecuteInDir(meta_command)
let out = go#util#System(meta_command)
Copy link
Contributor

@arp242 arp242 Aug 21, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing, but a comment a few lines up (line 58) says:

" For sync mode (go#tool#ExecuteInDir), always explicitly pass the 5 seconds
" deadline if there is no other deadline configured. If a deadline is
" configured, then use it.

But this is no longer accurate.

Could you also update the comment? This is the sort of small function/code mismatch that can cause a lot of confusion in the (distant) future ;-)


let l:listtype = "quickfix"
if go#util#ShellError() == 0
Expand Down