neovim: invoke guru functions via async api #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1678 +/- ##
==========================================
- Coverage 19.75% 19.73% -0.03%
==========================================
Files 57 57
Lines 4738 4748 +10
==========================================
+ Hits 936 937 +1
- Misses 3802 3811 +9
Continue to review full report at Codecov.
|
|
Thank you for the contribution @entombedvirus. I'm working on resolving the conflicts and will test these changes this weekend. |
Previously, enabling auto_same_ids and auto_type_info in neovim on large go projects resulted in a noticeable UI pause while neovim was waiting for the guru process to produce output. This was not a problem in Vim8 since vim-go already uses the job_start async api for Vim8. This commit enables transparent use of neovim jobstart api to accomplish the same async behavior in neovim. This commit also fixes a bug where enabling auto_same_ids prevented :GoImplements from correctly popping up the location list.
|
@entombedvirus do you mind if I force push over your branch with the rebased changes? |
|
👍 Go for it. |
bhcleek
force-pushed
the
rohith/async-guru-neovim
branch
from
c91792e to
ba2a1e8
Compare
|
Thank you. |
bhcleek
added a commit
that referenced
this pull request
Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, enabling auto_same_ids and auto_type_info in neovim on large
go projects resulted in a noticeable UI pause while neovim was waiting
for the guru process to produce output. This was not a problem in Vim8
since vim-go already uses the job_start async api for Vim8.
This commit enables transparent use of neovim jobstart api to accomplish
the same async behavior in neovim. This commit also fixes a bug where
enabling auto_same_ids prevented :GoImplements from correctly popping up
the location list.