Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for locationlist or quickfix list stealing focus on save. #1679

Closed
wants to merge 3 commits into from

Conversation

mikijov
Copy link

@mikijov mikijov commented Feb 21, 2018

Related to issue #1073. The issue must have regressed since the fix in #1293. The PR is simply re-adding original fix, albeit to different location since the codebase has changed.

I have fixed the tests as well. However, I am not very familiar with how vim testing works, so I would appreciate someone verifying it.

@codecov-io
Copy link

codecov-io commented Feb 21, 2018

Codecov Report

Merging #1679 into master will increase coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1679      +/-   ##
==========================================
+ Coverage   22.36%   22.42%   +0.06%     
==========================================
  Files          53       53              
  Lines        4226     4231       +5     
==========================================
+ Hits          945      949       +4     
- Misses       3281     3282       +1
Flag Coverage Δ
#nvim 16.94% <40%> (+0.02%) ⬆️
#vim74 19.42% <40%> (+0.02%) ⬆️
#vim80 21.17% <40%> (+0.02%) ⬆️
Impacted Files Coverage Δ
autoload/go/lint.vim 58.28% <80%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0467c...444a75f. Read the comment docs.

@bhcleek
Copy link
Collaborator

bhcleek commented Feb 21, 2018

Thank you for the contribution!

This will affect all codepaths that populate and show the error lists, not just on save. Can you target the fix to apply only to linting that happens when saving the file?

@mikijov
Copy link
Author

mikijov commented Feb 22, 2018

Well, here you go. Thanks for pushing me to learn a bit of vimscript. Now I feel I accomplished something (as compared to 8 hours of meetings). :-) I hope it's what you wanted.

@bhcleek bhcleek self-requested a review February 22, 2018 04:34
@bhcleek
Copy link
Collaborator

bhcleek commented Feb 22, 2018

Thanks @mikijov. On first glance, this looks right.

@bhcleek
Copy link
Collaborator

bhcleek commented Mar 2, 2018

Thank you @mikijov . With some slight modifications, your changes have been incorporated into master as of eaef6f7

@bhcleek bhcleek closed this Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants