Fix various race conditions when using terminal windows #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Explicitly close the terminal window instead of assuming the terminal window is the current window and closing that. * Eliminate the outstanding job list in favor of using a more object oriented like approach. * Make sure the correct location list gets used instead of assuming that the current window is the window whose location list should be used. Fixes fatih#1720
Codecov Report
@@ Coverage Diff @@
## master #1721 +/- ##
==========================================
+ Coverage 19.57% 19.62% +0.04%
==========================================
Files 57 57
Lines 4787 4775 -12
==========================================
Hits 937 937
+ Misses 3850 3838 -12
Continue to review full report at Codecov.
|
|
tested it with nvim. lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window is the current window and closing that.
oriented like approach.
the current window is the window whose location list should be used.
Fixes #1720