Fix term enabled behavior #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the startinsert and stopinsert pair; they cancel each other out and are unnecessary.
Window numbers are mutable; it's only window ids that don't change. When g:go_term_enabled=1, make sure that the window from which terminal commands are run is made active again regardless of the value of splitting options (e.g. 'splitright').
Codecov Report
@@ Coverage Diff @@
## master #1725 +/- ##
==========================================
+ Coverage 23.94% 24.91% +0.97%
==========================================
Files 57 57
Lines 4766 4761 -5
==========================================
+ Hits 1141 1186 +45
+ Misses 3625 3575 -50
Continue to review full report at Codecov.
|
fatih
reviewed
Mar 20, 2018
| if state.winnr !=# winnr() | ||
| exe state.winnr . "wincmd w" | ||
| endif | ||
| call win_gotoid(state.winid) |
There was a problem hiding this comment.
It is. We actually probably need to be using it many other places, but all the other cases where it should be used but isn't requires an unlikely edge case before a user would notice a problem. Because of the way the terminal works, though, we must use the window id instead of the window number to make sure the behavior is the same regardless of the value of splitright.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that behavior is consistent when
g:go_term_enabled=1regardless of the value of thesplitrightoption.Remove the startinsert and stopinsert pair; they cancel each other out
and are unnecessary.
remove superfluous stderr callback.