use window id instead of number in all async jobs #1734
Conversation
Use window ids instead of window numbers to select windows in all async job callbacks so that the correct window is selected even when the user modifies the window layout between when the job is started and when the callback is executed.
| let l:listtype = go#list#Type(self.for) | ||
| if a:exit_status == 0 | ||
| call go#list#Clean(l:listtype) | ||
| call win_gotoid(l:winid) |
There was a problem hiding this comment.
This is slightly confusing. We jump two times. First to the windows where the job was started, and then to the current window. Why do we have a logic like this? If we jump to the window the job was started, I wouldn't want to go back, but I think here we jump back because there are no errors right ? Maybe we should have an if .. else ... clause instead of jumping twice.
There was a problem hiding this comment.
Assume the user has 2 windows open. While in window 1, the user runs an async command whose list type is locationlist. Before the async command completes, the user moves to window 2. Then the async command completes successfully. We need to clean the list of window 1 (hence the first jump). And we want to avoid stealing window focus, so we make window 2 active again before returning from the callback.
|
lgtm |
Use window ids instead of window numbers to select windows in all async
job callbacks so that the correct window is selected even when the user
modifies the window layout between when the job is started and when the
callback is executed.