Warn when running go#cmd#autowrite() without autowrite enabled #1754
Conversation
|
I added a 1 second sleep to make the error message a bit more visible. It's a bit meh, but not sure how to do it better without completely revamping the way we echo messages. |
|
1 second for each file that's modified could be excessive. Maybe do that after iterating if any buffers are modified? |
|
Ah yes, that is a bit silly. I changed it to show the message once only, which is also what |
|
Does the message disappear due to a redraw without the sleep? Assuming yes, lgtm. |
Not due to redaw as such, but because |
|
Ship it. |
The `go#cmd#autowrite()` will write buffers to disk for commands that operate on files (rather than buffers). This is useful, but if you *don't* have this option enabled you never get an error message. This changed that to show a non-fatal warning. This is the same behaviour as the `:make` command. Right now this doesn't work very well because the various status messages from the jobs push the error away, making it hard to see (I don't get the expected "hit enter" prompt), so we need a better solution for that first.
| " often immediacy overwritten by the async messages (which also don't | ||
| " invoke the "hit ENTER" prompt). | ||
| call go#util#EchoWarning('[No write since last change]') | ||
| sleep 1 |
There was a problem hiding this comment.
Will sleep block any other running async calls? Seems like a dangerous thing to add in that case.
The
go#cmd#autowrite()will write buffers to disk for commands thatoperate on files (rather than buffers). This is useful, but if you
don't have this option enabled you never get an error message.
This changed that to show a non-fatal warning. This is the same
behaviour as the
:makecommand.Right now this doesn't work very well because the various status
messages from the jobs push the error away, making it hard to see (I
don't get the expected "hit enter" prompt), so we need a better solution
for that first.