Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go syntax: no goReceiverType in goVar #1794

Merged
merged 1 commit into from
Aug 25, 2018
Merged

Fix go syntax: no goReceiverType in goVar #1794

merged 1 commit into from
Aug 25, 2018

Conversation

powerman
Copy link
Contributor

@powerman powerman commented Apr 11, 2018

Identifier after a pointer inside var() block incorrectly highlighted as goReceiverType:

let g:go_highlight_functions = 1
var (
	one = make(map[string]*wrongHERE.something)
	two *wrongHERE.something
)

@fatih
Copy link
Owner

fatih commented Apr 11, 2018

Hi @powerman

Can you please send a before/after picture. Even though I've added your change, nothing has changed for me.

@powerman
Copy link
Contributor Author

Sorry, it's activated by let g:go_highlight_functions = 1, not g:go_highlight_types.
vim-go-1
And then I press Enter (notice prepared vim command line above) and got this:
vim-go-2

@arp242 arp242 self-assigned this May 25, 2018
@arp242
Copy link
Contributor

arp242 commented May 25, 2018

Note that let g:go_highlight_functions = 1 is documented as:

Highlight function and method declarations.

So I'm not sure why you expect that to highlight url in the above example?

All these highlight settings and their interactions are so messy :-(

@powerman
Copy link
Contributor Author

So I'm not sure why you expect that to highlight url in the above example?

I'm expecting it to not highlight anything inside var(…), but it does highlight it. PR fixed that.

@bhcleek bhcleek merged commit d7d6a70 into fatih:master Aug 25, 2018
bhcleek added a commit that referenced this pull request Aug 25, 2018
@powerman powerman deleted the fix-highlight-goVar branch August 26, 2018 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants