Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

def: only add build tags if it's present #1882

Merged
merged 1 commit into from
Jul 18, 2018
Merged

def: only add build tags if it's present #1882

merged 1 commit into from
Jul 18, 2018

Conversation

fatih
Copy link
Owner

@fatih fatih commented Jul 16, 2018

fixes #1865

@bhcleek
Copy link
Collaborator

bhcleek commented Jul 16, 2018

I'm surprised that this is an issue only for godef. If this is a problem on Windows for godef, then presumably lots of other commands will have this same problem (re: #1771)

@fatih
Copy link
Owner Author

fatih commented Jul 17, 2018

@bhcleek yeap could be indeed. However I dont' have a windows machine and I think we'll probably see it coming (through reports) if that is the case. Let's merge this and then fix all others if this still happens.

@fatih fatih force-pushed the fix-build-tags-def branch 3 times, most recently from ca80369 to f2d8c88 Compare July 17, 2018 21:54
@bhcleek
Copy link
Collaborator

bhcleek commented Jul 17, 2018

lgtm

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
fixes #1865
@fatih fatih force-pushed the fix-build-tags-def branch from f2d8c88 to e19a3ea Compare July 18, 2018 10:21
@fatih fatih merged commit 1debe9b into master Jul 18, 2018
@fatih fatih deleted the fix-build-tags-def branch July 18, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GoDef does not work on Windows if g:go_build_tags is not specified
2 participants