New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error at go#def#jump_to_declaration when vim-go uses godef #2141

Merged

bhcleek merged 1 commit into fatih:master from dzruyk:godef_fix

Feb 11, 2019

Contributor

dzruyk commented Feb 10, 2019 •

edited

Loading

Godef outputs only one line when user tries to jump to module definition,
because of that vim-go shows following error:

Error detected while processing function go#def#Jump[70]..go#def#jump_to_declaration:
line   17:
E684: list index out of range: 1
E15: Invalid expression: parts[1]

This PR fixes the issue and adds few additional checks.


          fix error at go#def#jump_to_declaration when vim-go uses godef

40c9de2

Collaborator

bhcleek commented Feb 11, 2019

Thank you

bhcleek merged commit 40c9de2 into fatih:master

bhcleek added a commit that referenced this pull request


          Merge pull request #2141 from dzruyk/godef_fix

89b7aff

bhcleek added a commit that referenced this pull request


          update CHANGELOG.md for #2141

484537f

dzruyk deleted the godef_fix branch

March 17, 2019 13:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet