Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: do not duplicate errors in quickfix on save #2810

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Apr 6, 2020

lint: fix function reference

Fix references to s:preserveerrors to avoid an error when using the
function reference.

lint: allow errors to be cleared on save
  • Allow errors to be cleared on save.
  • Take a:autosave into account in s:preserveerrors so that errors won't
    be preserved unexpectedly.
  • Normalize some strings relevant to this change to use single quoted
    strings instead of double quoted strings.

Fixes #2809

bhcleek added 2 commits April 6, 2020 14:33
Fix references to s:preserveerrors to avoid an error when using the
function reference.
* Allow errors to be cleared on save.
* Take a:autosave into account in s:preserveerrors so that errors won't
  be preserved unexpectedly.
* Normalize some strings relevant to this change to use single quoted
  strings instead of double quoted strings.

Fixes fatih#2809
@bhcleek bhcleek force-pushed the lint/preserve-errors branch from e86d827 to cb1206b Compare April 6, 2020 21:53
@bhcleek bhcleek merged commit dab3d36 into fatih:master Apr 6, 2020
@bhcleek bhcleek deleted the lint/preserve-errors branch April 6, 2020 22:26
@bhcleek bhcleek added this to the vim-go 1.23 milestone Apr 6, 2020
bhcleek added a commit that referenced this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quickfix window persists/duplicates errors when GoMetalinter runs on save
1 participant