Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GoDocBrowser to work with latest gopls #3112

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Fix GoDocBrowser to work with latest gopls #3112

merged 1 commit into from
Dec 12, 2020

Conversation

reegnz
Copy link
Contributor

@reegnz reegnz commented Dec 12, 2020

Fixes #3111

@reegnz
Copy link
Contributor Author

reegnz commented Dec 12, 2020

FYI the breaking change in gopls was this one:

golang/tools@9712d02

@reegnz
Copy link
Contributor Author

reegnz commented Dec 12, 2020

I also noticed that these link fields are not following the LSP standard, so might break again in the future.

@bhcleek bhcleek added this to the vim-go 1.25 milestone Dec 12, 2020
@bhcleek
Copy link
Collaborator

bhcleek commented Dec 12, 2020

Thank you

@bhcleek bhcleek merged commit 62e44f0 into fatih:master Dec 12, 2020
bhcleek added a commit that referenced this pull request Dec 12, 2020
Add a leading space in a code comment.

Revert change in case of first letter of an error message.
bhcleek added a commit that referenced this pull request Dec 12, 2020
@reegnz reegnz deleted the fix_GoDocBrowser branch December 13, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GoDocBrowser broken with latest gopls
2 participants