Re-evaluate sameids after buffer is re-entered #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When g:go_auto_sameids is not set, re-apply :GoSameIds after the buffer is displayed in a window. This ensures that once the user has called :GoSameIds, the highlighting will be applied in the buffer based on the cursor position at the time of evaluation until the user calls :GoSameIdsClear, even if the buffer is reloaded into the same window ( e.g. :GoRename, or even reloading the file from disk manually).
| if get(g:, "go_auto_sameids", 0) | ||
| " re-apply SameIds at the current cursor position at the time the buffer | ||
| " is redisplayed: e.g. :edit, :GoRename, etc. | ||
| autocmd BufWinEnter <buffer> nested call go#guru#SameIds(-1) |
There was a problem hiding this comment.
So this is called because we call :e inside :GoRename, which loads the buffer and thus it triggers this line right ? I wonder if there is a case that doesn't remove the trigger below.
There was a problem hiding this comment.
That's exactly right. But the nice thing about this approach, is that it will do the right thing even the user does :edit.
I don't think there's a case that fails to remove the buffer-local autocommand; the only case I could think of is when the buffer is wiped out, but in that case the buffer-local autocommand will be removed by Vim.
|
Alright, let us use this a little bit, if there is any errors we'll catch them up. Thanks @bhcleek 👍 |
|
Sounds good to me! Thanks, @fatih. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When g:go_auto_sameids is not set, re-apply :GoSameIds after the buffer
is displayed in a window. This ensures that once the user has called
:GoSameIds, the highlighting will be applied in the buffer based on the
cursor position at the time of evaluation until the user calls
:GoSameIdsClear, even if the buffer is reloaded into the same window (
e.g. :GoRename, or even reloading the file from disk manually).