Made enabling OverlayInteraction option clearer #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2024 11:01
Setting preventOverlayInteraction to false deactivates focus trap
✅ Deploy Preview for eloquent-lamport-f2ffa1 canceled.
|
✅ Deploy Preview for beamish-dango-bc9c2d canceled.
|
|
Thank you for your contribution @Wisdawg ! I apologize for the delayed response. Here's what I'll do:
I'll implement these changes and merge them soon. Thanks again for your contribution! 🙏 |
This reverts commit 29b0758.
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting OverlayInteraction of a step or tour to true now allows click events to fire even if there's not a tabbable element in the VOnboardingStep. Seems to address Issue 100.