Made support-email configurable, fixes #100 #108

sedrubal · 2015-11-22T02:57:48Z

needs testing, because it would be bad if no error message will be displayed, because of such a trivial mistake, but I don't know how to trigger suitable errors, besides the DebtLimitExceeded exception - there it works...
is vulnerable to crash on missing config option #63

landscape-bot · 2015-11-22T03:06:21Z

Repository health decreased by 0.14% when pulling 7c528af on support-mail-config into 4a4d884 on development.

3 new problems were found (including 1 error and 1 code smell).
1 problem was fixed (including 0 errors and 0 code smells).

landscape-bot · 2015-11-22T03:47:48Z

Repository health decreased by 0.06% when pulling 9d1b4de on support-mail-config into 4a4d884 on development.

2 new problems were found (including 0 errors and 1 code smell).
1 problem was fixed (including 0 errors and 0 code smells).

patkan · 2015-11-23T01:36:02Z

@sedrubal I was just too fast with assigning, the commit should fix your problem ;-)

patkan · 2015-11-27T14:39:39Z

Seems to be ok.
@sedrubal you could rebase this PR to one commit and then we could merge it.

mgmax · 2015-11-27T16:10:18Z

FabLabKasse/scriptHelper.py

@@ -64,11 +64,12 @@ def myNewExceptionHook(exctype, value, tb):
        import datetime
        # logging.exception()
        try:
+            cfg = getConfig()
+            email = cfg.get('general', 'support_mail')


please catch ConfigParser.Error here so that the crash handler can't crash

patkan · 2015-11-27T16:39:56Z

Sorry, had to rebase due to sloppiness.
This should work now.

mgmax · 2015-11-27T21:05:00Z

FabLabKasse/scriptHelper.py

+                email = cfg.get('general', 'support_mail')
+            except ConfigParserError:
+                logging.warning("could not read mail address from config in graphical except-hook.")
+                email = "dex Verantwortlichx"


typo? or gender bullshit?

Man muss natürlich richtig gendern und so.
Spaß beiseite, ich dachte mir man kann das als easter egg einbauen, du darfst es aber auch gerne ändern :-P

- needs testing, - is vulnerable to #63 This commit contains 9d1b4de Fixed syntax, TODO: cfg and 0ffd19a FIX pass cfg object into payment_methods

… supplied in config

patkan · 2016-01-16T08:49:59Z

I have rebased this branch against current development.

sedrubal · 2016-01-16T10:30:51Z

Can we merge this? :)

mgmax · 2016-01-16T20:39:01Z

the 'dex Verantwortlichx' should still be changed, maybe just to 'den Verantwortlichen'.

sedrubal · 2016-01-17T02:03:35Z

I like this hidden ironical political and social criticism. But if you worry about that, I think its no problem to change this.

Sometime in the future we should also change such messages to english and use internationalization and translations...

patkan · 2016-01-17T11:04:10Z

we could try to implement a test, that checks whether the graphical except-hook is working. However, in sum this is probably not worth the time.

sedrubal · 2016-01-19T19:09:36Z

I think, we can merge this, too. Until 21:00

patkan · 2016-01-19T19:11:42Z

That's OK for me.

Fixes #100 and #108

sedrubal assigned patkan Nov 22, 2015

sedrubal added the wip label Nov 22, 2015

patkan assigned sedrubal and unassigned patkan Nov 23, 2015

mgmax reviewed Nov 27, 2015
View reviewed changes

patkan force-pushed the support-mail-config branch from ebd26a9 to b14f1ad Compare November 27, 2015 16:39

mgmax reviewed Nov 27, 2015
View reviewed changes

sedrubal added low-prio ready-to-merge and removed wip labels Dec 11, 2015

sedrubal and others added 2 commits January 16, 2016 09:24

Made support-email configurable, fixes #100

1f2531e

- needs testing, - is vulnerable to #63 This commit contains 9d1b4de Fixed syntax, TODO: cfg and 0ffd19a FIX pass cfg object into payment_methods

IMPROVE do not let graphical except hook fail when no mail address is…

ac6a2a1

… supplied in config

patkan force-pushed the support-mail-config branch from 1e36da0 to 5f8bbe5 Compare January 16, 2016 08:28

patkan and others added 3 commits January 17, 2016 12:01

replace 'dex Verantwortlichx' in order to make @mgmax happy 🎁

4a48131

Catch ConfigParserError when requesting support_mail for error messages

d9d4fa3

IMPROVE add explicit locations to format()

e6ec98d

patkan force-pushed the support-mail-config branch from 1943beb to e6ec98d Compare January 17, 2016 11:02

sedrubal merged commit e6ec98d into development Jan 19, 2016

sedrubal pushed a commit that referenced this pull request Jan 19, 2016

Merge branch 'support-mail-config' into development

b1cb9eb

Fixes #100 and #108

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Made support-email configurable, fixes #100 #108

Made support-email configurable, fixes #100 #108

sedrubal commented Nov 22, 2015

landscape-bot commented Nov 22, 2015

landscape-bot commented Nov 22, 2015

patkan commented Nov 23, 2015

patkan commented Nov 27, 2015

mgmax Nov 27, 2015

patkan commented Nov 27, 2015

mgmax Nov 27, 2015

patkan Nov 27, 2015

patkan commented Jan 16, 2016

sedrubal commented Jan 16, 2016

mgmax commented Jan 16, 2016

sedrubal commented Jan 17, 2016

patkan commented Jan 17, 2016

sedrubal commented Jan 19, 2016

patkan commented Jan 19, 2016

Made support-email configurable, fixes #100 #108

Made support-email configurable, fixes #100 #108

Conversation

sedrubal commented Nov 22, 2015

landscape-bot commented Nov 22, 2015

landscape-bot commented Nov 22, 2015

patkan commented Nov 23, 2015

patkan commented Nov 27, 2015

mgmax Nov 27, 2015

Choose a reason for hiding this comment

patkan commented Nov 27, 2015

mgmax Nov 27, 2015

Choose a reason for hiding this comment

patkan Nov 27, 2015

Choose a reason for hiding this comment

patkan commented Jan 16, 2016

sedrubal commented Jan 16, 2016

mgmax commented Jan 16, 2016

sedrubal commented Jan 17, 2016

patkan commented Jan 17, 2016

sedrubal commented Jan 19, 2016

patkan commented Jan 19, 2016