Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install fakencclient for all python package installs. #4385

Merged
merged 1 commit into from
Oct 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docker/install-faucet.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ FROOT="/faucet-src"
dir=$(dirname "$0")

${APK} add -U ${BUILDDEPS}
"${dir}/retrycmd.sh" "${PIP3} git+https://github.com/faucetsdn/python3-fakencclient"
"${dir}/retrycmd.sh" "${PIP3} ${TESTDEPS}"
"${dir}/retrycmd.sh" "${PIP3} -r ${FROOT}/requirements.txt"
${PIP3} ${FROOT}
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ ruamel.yaml==0.17.26
os_ken==2.6.0
beka==0.4.2
pytricia>=1.0.0
https://github.com/faucetsdn/python3-fakencclient/archive/main.tar.gz
2 changes: 2 additions & 0 deletions tests/unit/packaging/test_packaging.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ def _parse_pip_requirements(self, requirements_file):
self.faucet_pip_reqs = {}
with open(requirements_file, "r", encoding="utf-8") as handle:
for pip_req in requirements.parse(handle):
if pip_req.name is None:
continue
self.faucet_pip_reqs[pip_req.name] = pip_req.specs

def _pip_req_to_dpkg_name(self, pip_req):
Expand Down
Loading