Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Guzzle client timeout #10

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

litencatt
Copy link
Contributor

@litencatt litencatt commented Jul 31, 2018

Now Guzzle client timeout is set fix value 5.0 in Notifier::postNotice().

protected function postNotice($url, $notice)
{
$client = new Client();
$config = [
'headers' => [
'Content-Type' => 'application/json',
'x-api-key' => $this->opt['apiKey']
],
'json' => $notice,
'timeout' => 5.0,

But we want to change timeout value.
So this PR changes Guzzle client timeout to configurable.

@k1LoW
Copy link
Member

k1LoW commented Jul 31, 2018

@litencatt Thank you for your NICE WORK!!!!

@k1LoW k1LoW merged commit 68b5188 into faultline:master Jul 31, 2018
@k1LoW
Copy link
Member

k1LoW commented Jul 31, 2018

Released as v0.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants