Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NullDoc support #101

Merged
merged 6 commits into from
Jun 21, 2023
Merged

Add NullDoc support #101

merged 6 commits into from
Jun 21, 2023

Conversation

cynicaljoy
Copy link
Contributor

@cynicaljoy cynicaljoy commented Jun 20, 2023

Ticket(s): BT-3662

Problem

Drivers need to support handling null doc references

Solution

  • If @ref contains exists==false return a NullDocument or NullNamedDocument depending on the Ref

Result

Consumes are able to test for NullDocument responses.

Testing

Include go test


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cynicaljoy cynicaljoy changed the title Null doc support Add NullDoc support Jun 20, 2023
@cynicaljoy cynicaljoy marked this pull request as ready for review June 20, 2023 17:02
@cynicaljoy cynicaljoy requested review from pnwpedro and sprsquish and removed request for pnwpedro June 20, 2023 17:02
serializer.go Outdated Show resolved Hide resolved
@cynicaljoy cynicaljoy requested a review from sprsquish June 20, 2023 17:31
serializer.go Outdated Show resolved Hide resolved
Co-authored-by: Jeff Smick <jeff@squishtech.com>
@cynicaljoy cynicaljoy merged commit 92bf9cf into main Jun 21, 2023
@cynicaljoy cynicaljoy deleted the null-doc-support branch June 21, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants