Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone the body during backoff/retry #127

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Clone the body during backoff/retry #127

merged 3 commits into from
Sep 12, 2023

Conversation

pnwpedro
Copy link
Collaborator

@pnwpedro pnwpedro commented Sep 12, 2023

Ticket(s): BT-4177

Problem

We have a bug where the backoff / retry implementation reuses a request, which is not valid.

Solution

  • Refactor the implementation from a recursive one to a simple loop
  • Clone the request and assign the body prior to each attempt

Result

What will change as a result of your pull request? Note that sometimes this section is unnecessary because it is self-explanatory based on the solution.

Testing

  • Verified against a lower environment cluster

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pnwpedro pnwpedro merged commit 058d620 into main Sep 12, 2023
@pnwpedro pnwpedro deleted the clonethebody branch September 12, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants