-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Axios #66
Merged
Merged
Replace Axios #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptpaterson
commented
Feb 22, 2023
cleve-fauna
force-pushed
the
FE-3060-replace-axios
branch
from
February 23, 2023 16:24
af69173
to
5915824
Compare
ptpaterson
force-pushed
the
FE-3060-replace-axios
branch
from
February 23, 2023 16:53
5915824
to
38543de
Compare
cleve-fauna
reviewed
Feb 23, 2023
ptpaterson
force-pushed
the
FE-3060-replace-axios
branch
from
February 23, 2023 20:02
9e3151d
to
3a32ad5
Compare
cleve-fauna
reviewed
Feb 24, 2023
cleve-fauna
force-pushed
the
FE-3060-replace-axios
branch
from
February 24, 2023 17:16
4af03b8
to
841a6b4
Compare
cleve-fauna
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-3060
Problem
We need to get rid of Axios, because it does not work in a lot of environments
Solution
Provide an initial implementation that just uses the native fetch API in browsers and Node. Add a custom fetch function to the client configuration that we can later provide various per-environment implementations (e.g. HTTP2 in Node), or that users can also provide.
Result
Driver works with browsers and Node.
Out of scope
// WIP
comments where it should be straightforward to drop that in when we're ready.Testing
Tests updated to reflect new API. Notes:
__tests__/integration/connection-pool.test.ts
__tests__/unit/query.test.ts
. We should review and either delete them or determine their analog for the new HTTPClient.