fix: --max-backoff
accepts seconds, not ms
#588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The help text and tests for
--max-backoff
flag state/imply it accepts milliseconds.The JS driver's corresponding
maxBackoff
client config option accepts values in seconds, not milliseconds. The value is converted from seconds to milliseconds here: https://github.com/fauna/fauna-js/blob/main/src/client.ts#L467-L468Unless I missed it, the CLI does do any conversion of
--max-backoff
values so it should accept seconds.Solution
Update the help text and tests to indicate
--max-backoff
accepts seconds.Result
Accurate help and tests for the CLI.
Testing
npm run test:local
is 🟢