Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala 2.12.13 #292

Merged
merged 5 commits into from
Jun 7, 2021
Merged

scala 2.12.13 #292

merged 5 commits into from
Jun 7, 2021

Conversation

agourlay
Copy link
Contributor

@lregnier
Copy link
Contributor

Make sure to update references to 2.12.12 in .circle/config.yml as well :)

@agourlay
Copy link
Contributor Author

Everything works fine locally but it fails on CircleCI because the sbt-scoverage plugin has not been updated yet.
scoverage/sbt-scoverage#319

@lregnier
Copy link
Contributor

Ha! It looks like we are going need to wait then?

@agourlay
Copy link
Contributor Author

@lregnier the plugin was released but it does not support Scala 2.11 anymore.
I propose to simply not run test coverage on the 2.11 build.
WDYT?

Copy link
Contributor

@lregnier lregnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to simply not run test coverage on the 2.11 build.

Looks good to me!

@faunaee
Copy link
Contributor

faunaee commented Jun 4, 2021

Does this mean that we no longer support using the Scala driver with Scala 2.11.x?

@agourlay
Copy link
Contributor Author

agourlay commented Jun 7, 2021

@faunaee We are still supporting Scala 2.12 and 2.11 👍

The issue here is an incompatibility with the SBT plugin with use to generate test coverage report that we run as part of the build.
As this plugin does not support Scala 2.11 anymore, we will only generate test coverage report for Scala 2.12 which is IMHO ok as we do not have specific 2.11 code in the project.

@agourlay
Copy link
Contributor Author

agourlay commented Jun 7, 2021

I took the liberty to update to Scala 2.14 :)

@agourlay agourlay merged commit 6ca12db into master Jun 7, 2021
@agourlay agourlay deleted the scala-2.12.13 branch June 7, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants