refactor: optimize getGamesJapan

favna · Aug 21, 2022 · 70c61cd · 70c61cd
1 parent e6ad25f
commit 70c61cd
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/lib/getGames/getGamesJapan.ts b/src/lib/getGames/getGamesJapan.ts
@@ -5,6 +5,8 @@ import { JP_GET_GAMES_URL } from '../utils/constants';
 import type { GameJP } from '../utils/interfaces';
 import { EshopError } from '../utils/utils';
 
+const parser = new XMLParser();
+
 /**
  * Fetches all games on japanese eShops
  *
@@ -17,15 +19,11 @@ export const getGamesJapan = async (): Promise<GameJP[]> => {
     throw new EshopError('Fetching of JP Games failed');
   }
 
-  const parser = new XMLParser();
-
-  const gamesJP = Result.from(parser.parse(response.unwrap()));
+  const gamesJP = Result.from(() => parser.parse(response.unwrap()));
 
   if (gamesJP.isErr()) {
     throw new EshopError('Parsing of JP Games failed');
   }
 
-  const allGamesJP: GameJP[] = gamesJP.unwrap().TitleInfoList.TitleInfo;
-
-  return allGamesJP;
+  return gamesJP.unwrap().TitleInfoList.TitleInfo as GameJP[];
 };