test: improve coverage

favonia · Sep 5, 2022 · 76d0293 · 76d0293
1 parent c3f8fbb
commit 76d0293
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 2 deletions.
diff --git a/internal/config/config_test.go b/internal/config/config_test.go
@@ -881,6 +881,28 @@ func TestNormalize(t *testing.T) {
 				)
 			},
 		},
+		"template/error/proxied/ill-formed": {
+			input: &config.Config{ //nolint:exhaustruct
+				Provider: map[ipnet.Type]provider.Provider{
+					ipnet.IP6: provider.NewCloudflareTrace(),
+				},
+				Domains: map[ipnet.Type][]domain.Domain{
+					ipnet.IP6: {domain.FQDN("a.b.c")},
+				},
+				TTLTemplate:     `1`,
+				ProxiedTemplate: `{{domain 12345}}`,
+			},
+			ok:       false,
+			expected: nil,
+			prepareMockPP: func(m *mocks.MockPP) {
+				gomock.InOrder(
+					m.EXPECT().IsEnabledFor(pp.Info).Return(true),
+					m.EXPECT().Infof(pp.EmojiEnvVars, "Checking settings . . ."),
+					m.EXPECT().IncIndent().Return(m),
+					m.EXPECT().Errorf(pp.EmojiUserError, "Could not execute the template %q: %v", "{{domain 12345}}", gomock.Any()), //nolint:lll
+				)
+			},
+		},
 	} {
 		tc := tc
 		t.Run(name, func(t *testing.T) {

diff --git a/internal/domain/fqdn_test.go b/internal/domain/fqdn_test.go
@@ -20,7 +20,6 @@ func TestFQDNString(t *testing.T) {
 	))
 }
 
-//nolint:dupl
 func TestFQDNDescribe(t *testing.T) {
 	t.Parallel()
 	for _, tc := range [...]struct {
@@ -67,6 +66,7 @@ func TestFQDNDescribe(t *testing.T) {
 	}
 }
 
+//nolint:dupl
 func TestFQDNSplitter(t *testing.T) {
 	t.Parallel()
 	type r = string

diff --git a/internal/domain/wildcard_test.go b/internal/domain/wildcard_test.go
@@ -23,7 +23,6 @@ func TestWildcardString(t *testing.T) {
 	))
 }
 
-//nolint:dupl
 func TestWildcardDescribe(t *testing.T) {
 	t.Parallel()
 	for _, tc := range [...]struct {
@@ -58,6 +57,7 @@ func TestWildcardDescribe(t *testing.T) {
 		{"xn--mgba3gch31f.de", "*.نامهای.de"},
 		{"xn--mgba3gch31f060k.de", "*.نامه\u200cای.de"},
 		// some other test cases
+		{"", "*"},
 		{"xn--a.xn--a.xn--a.com", "*.xn--a.xn--a.xn--a.com"},
 		{"a.com....", "*.a.com...."},
 		{"a.com", "*.a.com"},
@@ -70,6 +70,7 @@ func TestWildcardDescribe(t *testing.T) {
 	}
 }
 
+//nolint:dupl
 func TestWildcardSplitter(t *testing.T) {
 	t.Parallel()
 	type r = string