test(env): test the parsing of "url:..."

favonia · Aug 19, 2023 · 9749d96 · 9749d96
1 parent d6accec
commit 9749d96
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/internal/config/env_provider.go b/internal/config/env_provider.go
@@ -107,8 +107,8 @@ func ReadProvider(ppfmt pp.PP, key, keyDeprecated string, field *provider.Provid
 		case val == "local":
 			*field = provider.NewLocal()
 			return true
-		case strings.HasPrefix(val, "custom.url:"):
-			url := strings.TrimSpace(strings.TrimPrefix(val, "custom.url:"))
+		case strings.HasPrefix(val, "url:"):
+			url := strings.TrimSpace(strings.TrimPrefix(val, "url:"))
 			*field = provider.NewCustom(url)
 			return true
 		case val == "none":

diff --git a/internal/config/env_provider_test.go b/internal/config/env_provider_test.go
@@ -19,11 +19,12 @@ func TestReadProvider(t *testing.T) {
 	keyDeprecated := keyPrefix + "DEPRECATED"
 
 	var (
-		none  provider.Provider
-		doh   = provider.NewCloudflareDOH()
-		trace = provider.NewCloudflareTrace()
-		local = provider.NewLocal()
-		ipify = provider.NewIpify()
+		none   provider.Provider
+		doh    = provider.NewCloudflareDOH()
+		trace  = provider.NewCloudflareTrace()
+		local  = provider.NewLocal()
+		ipify  = provider.NewIpify()
+		custom = provider.NewCustom("https://url.io")
 	)
 
 	for name, tc := range map[string]struct {
@@ -153,6 +154,7 @@ func TestReadProvider(t *testing.T) {
 		"cloudflare.doh":   {true, "    \tcloudflare.doh   ", false, "", none, doh, true, nil},
 		"none":             {true, "   none   ", false, "", trace, none, true, nil},
 		"local":            {true, "   local   ", false, "", trace, local, true, nil},
+		"custom":           {true, "   url:https://url.io   ", false, "", trace, custom, true, nil},
 		"ipify": {
 			true, "     ipify  ", false, "", trace, ipify, true,
 			func(m *mocks.MockPP) {