test(api): cover another weird case

favonia · Aug 12, 2024 · a55aa9e · a55aa9e
1 parent ae000db
commit a55aa9e
Showing 1 changed file with 33 additions and 9 deletions.
diff --git a/internal/api/cloudflare_waf_test.go b/internal/api/cloudflare_waf_test.go
@@ -546,15 +546,28 @@ func TestDeleteWAFList(t *testing.T) {
 type listItem = string
 
 func mockListItem(listItem listItem) cloudflare.ListItem {
-	return cloudflare.ListItem{
-		ID:         mockID(listItem, 0),
-		IP:         &listItem,
-		Redirect:   nil,
-		Hostname:   nil,
-		ASN:        nil,
-		Comment:    "",
-		CreatedOn:  nil,
-		ModifiedOn: nil,
+	if listItem == "" {
+		return cloudflare.ListItem{
+			ID:         mockID(listItem, 0),
+			IP:         nil,
+			Redirect:   nil,
+			Hostname:   nil,
+			ASN:        nil,
+			Comment:    "",
+			CreatedOn:  nil,
+			ModifiedOn: nil,
+		}
+	} else {
+		return cloudflare.ListItem{
+			ID:         mockID(listItem, 0),
+			IP:         &listItem,
+			Redirect:   nil,
+			Hostname:   nil,
+			ASN:        nil,
+			Comment:    "",
+			CreatedOn:  nil,
+			ModifiedOn: nil,
+		}
 	}
 }
 
@@ -667,6 +680,17 @@ func TestListWAFListItems(t *testing.T) {
 				)
 			},
 		},
+		"nil": {
+			1,
+			[]listItem{""},
+			1,
+			false, nil,
+			func(ppfmt *mocks.MockPP) {
+				ppfmt.EXPECT().Warningf(pp.EmojiImpossible,
+					"Found a non-IP in the list %q (ID: %s)",
+					"list", mockID("list", 0))
+			},
+		},
 	} {
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()