Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate possibly unmaintained ipify #270

Merged
merged 1 commit into from
Nov 14, 2022
Merged

fix: deprecate possibly unmaintained ipify #270

merged 1 commit into from
Nov 14, 2022

Conversation

favonia
Copy link
Owner

@favonia favonia commented Nov 14, 2022

Closes #269.

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #270 (3027012) into main (4c68907) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   85.35%   85.39%   +0.03%     
==========================================
  Files          29       29              
  Lines        1946     1951       +5     
==========================================
+ Hits         1661     1666       +5     
  Misses        274      274              
  Partials       11       11              
Flag Coverage Δ
unittests 85.39% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/config/env.go 98.61% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@favonia favonia merged commit 69b5d70 into main Nov 14, 2022
@favonia favonia deleted the deprecate-ipify branch November 14, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate ipify
1 participant