Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): implement custom URL providers #560

Merged
merged 8 commits into from
Aug 28, 2023
Merged

feat(provider): implement custom URL providers #560

merged 8 commits into from
Aug 28, 2023

Conversation

favonia
Copy link
Owner

@favonia favonia commented Aug 19, 2023

This introduces a new provider url:URL, for example url:https://api6.ipify.org. Closes #546.

@favonia favonia changed the title feat(provider): implement custom URLs feat(provider): implement custom URL providers Aug 19, 2023
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #560 (02e3f89) into main (f19f821) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   87.75%   87.83%   +0.07%     
==========================================
  Files          43       44       +1     
  Lines        2164     2178      +14     
==========================================
+ Hits         1899     1913      +14     
  Misses        256      256              
  Partials        9        9              
Flag Coverage Δ
unittests 87.83% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/config/env_provider.go 100.00% <100.00%> (ø)
internal/provider/custom.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@favonia favonia force-pushed the custom.http branch 2 times, most recently from a43a85e to 9749d96 Compare August 19, 2023 23:28
@favonia
Copy link
Owner Author

favonia commented Aug 19, 2023

@augustabt I will merge this when you okay it or when no comments are added within one week. Again, sorry for the delay.

@favonia favonia self-assigned this Aug 19, 2023
@favonia favonia merged commit 6318512 into main Aug 28, 2023
@favonia favonia deleted the custom.http branch August 28, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a custom provider
1 participant