Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): remove all trailing dots #95

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Conversation

favonia
Copy link
Owner

@favonia favonia commented Oct 18, 2021

Current it only removes one trailing dot.

Current it only removes one trailing dot.
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #95 (3ec9076) into main (342b7e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   77.90%   77.90%           
=======================================
  Files          22       22           
  Lines        1172     1172           
=======================================
  Hits          913      913           
  Misses        255      255           
  Partials        4        4           
Flag Coverage Δ
unittests 77.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/api/fqdn.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 342b7e8...3ec9076. Read the comment docs.

@favonia favonia merged commit f4ec041 into main Oct 18, 2021
@favonia favonia deleted the remove-all-trailing-dots branch October 18, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant