fix: ensure getByPokedexNumber has the correct boundaries

favware · Feb 25, 2024 · c232686 · c232686
1 parent be8403d
commit c232686
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/graphql/resolvers.graphql b/graphql/resolvers.graphql
@@ -40,7 +40,10 @@ type Query {
  "Whether to reverse the list of games from which to get the data. By default Generation 1 is considered for `take` first, when setting this to true that is instead Generation 8."
  reverseFlavorTexts: Boolean = true
 
- "The International PokéDex number of the Pokémon to look up"
+ """
+ The International PokéDex number of the Pokémon to look up.
+ The valid value ranges are (boundaries inclusive) `-5000` to `-5014` and `-72` to `1025`
+ """
  number: Int!
  ): Pokemon!
 

diff --git a/src/lib/validations/pokemonArgs/getPokemonByDexNumberArgs.ts b/src/lib/validations/pokemonArgs/getPokemonByDexNumberArgs.ts
@@ -10,7 +10,7 @@ export interface GetPokemonByDexNumberArgs extends BasePokemonArgs {
 }
 
 const getPokemonByDexNumberSchema: SchemaOf<GetPokemonByDexNumberArgs> = basePokemonArgsSchema.extend({
- number: s.number.greaterThanOrEqual(-68).lessThanOrEqual(905)
+ number: s.number.greaterThanOrEqual(-72).lessThanOrEqual(1025).or(s.number.greaterThanOrEqual(-5014).lessThanOrEqual(-5000))
 });
 
 export function validateGetPokemonByDexNumberArgs(args: GetPokemonByDexNumberArgs): NonNullish<GetPokemonByDexNumberArgs> {