Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fetch requests #36

Merged
merged 3 commits into from
Nov 16, 2019
Merged

Fix/fetch requests #36

merged 3 commits into from
Nov 16, 2019

Conversation

favna
Copy link
Member

@favna favna commented Nov 16, 2019

Please describe the changes this PR makes and why it should be merged:

Sprites were not parsed correctly for pokemon whom are alternate formes (i.e. pikachu-alola has to be pikachu-alola.gif not pikachualola.gif). Furthermore secondary evolutions were not showing up either.

Both bugs are fixed with this PR.

@favna favna self-assigned this Nov 16, 2019
@favna favna merged commit d51f009 into master Nov 16, 2019
@favna favna deleted the fix/fetch-requests branch November 16, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant