Add notion, make refresh token optional #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
dosubot
bot
added
the
size:L
ybw0014
requested changes
Feb 23, 2024
| state: encodedState, | ||
| response_type: "code", | ||
| owner: "user", | ||
| // scope: "", |
Collaborator
There was a problem hiding this comment.
Suggested change
| // scope: "", |
Comment on lines
34
to
35
| response_type: "code", | ||
| owner: "user", |
Collaborator
There was a problem hiding this comment.
move constant parameters into config provider.callbackUrlParams
| const encodedCredentials = Buffer.from(`${this.config.credentials.id}:${this.config.credentials.secret}`).toString("base64") | ||
| const tokenResponse = await exchangeCodeForToken(this.httpService, this.config, query.code, { | ||
| headers: { | ||
| Authorization: `Basic ${encodedCredentials}`, |
Collaborator
There was a problem hiding this comment.
no need to have extra headers
Author
There was a problem hiding this comment.
The Notion API requires extra headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.