Fix parsing case-sensitive attriute selectors #387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #378
I changed type for
ignoreCase
fromboolean
toboolean | undefined
because[foo=x]
and[foo=x s]
selectors are not the same, because some attributes case-insensitive (https://html.spec.whatwg.org/multipage/semantics-other.html#case-sensitivity-of-selectors) by default or it depends on document mode. Also there are differences between#foo
and[id=foo]
selectors: in quirks mode ID selector is case-insensitive but attribute selector is case-sensitive.