Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing case-sensitive attriute selectors #387

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Conversation

Semigradsky
Copy link
Contributor

@Semigradsky Semigradsky commented Jan 8, 2021

Closes #378

I changed type for ignoreCase from boolean to boolean | undefined because [foo=x] and [foo=x s] selectors are not the same, because some attributes case-insensitive (https://html.spec.whatwg.org/multipage/semantics-other.html#case-sensitivity-of-selectors) by default or it depends on document mode. Also there are differences between #foo and [id=foo] selectors: in quirks mode ID selector is case-insensitive but attribute selector is case-sensitive.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 784b1f0 on Semigradsky:377 into 2839e92 on fb55:master.

@fb55 fb55 merged commit 7a41152 into fb55:master Jan 9, 2021
@fb55
Copy link
Owner

fb55 commented Jan 9, 2021

Thanks a lot @Semigradsky! This will have to land as a major version, which means it is probably best to bundle it with a fix for #379.

@Semigradsky Semigradsky deleted the 377 branch January 9, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to parse case-sensitive selector
3 participants