Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): Use proxies to collect events #920

Merged
merged 2 commits into from
Aug 24, 2021
Merged

chore(tests): Use proxies to collect events #920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
848f742
chore(tests): Use proxies to collect events
fb55 Aug 23, 2021
0a6c735
Update Parser.spec.ts
fb55 Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions src/CollectingHandler.ts
View file
Open in desktop

This file was deleted.

63 changes: 0 additions & 63 deletions src/MultiplexHandler.ts
View file
Open in desktop

This file was deleted.

50 changes: 22 additions & 28 deletions src/Parser.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import { Parser, Tokenizer } from ".";
import type { Handler } from "./Parser";

describe("API", () => {
test("should work without callbacks", () => {
const cbs: Record<string, (t?: string) => void> = {};
const cbs: Partial<Handler> = { onerror: jest.fn() };
const p = new Parser(cbs, {
xmlMode: true,
lowerCaseAttributeNames: true,
Expand All @@ -13,71 +14,64 @@ describe("API", () => {

// Check for an error
p.end();
let err = false;
cbs.onerror = () => (err = true);
p.write("foo");
expect(err).toBeTruthy();
err = false;
expect(cbs.onerror).toHaveBeenLastCalledWith(
new Error(".write() after done!")
);
p.end();
expect(err).toBeTruthy();
expect(cbs.onerror).toHaveBeenLastCalledWith(
new Error(".end() after done!")
);

p.reset();

// Remove method
cbs.onopentag = () => {
/* Ignore */
};
cbs.onopentag = jest.fn();
p.write("<a foo");
delete cbs.onopentag;
p.write(">");

// Pause/resume
let processed = false;
cbs.ontext = (t) => {
expect(t).toBe("foo");
processed = true;
};
const onText = jest.fn();
cbs.ontext = onText;
p.pause();
p.write("foo");
expect(processed).toBeFalsy();
expect(onText).not.toHaveBeenCalled();
p.resume();
expect(processed).toBeTruthy();
processed = false;
expect(onText).toHaveBeenLastCalledWith("foo");
p.pause();
expect(processed).toBeFalsy();
expect(onText).toHaveBeenCalledTimes(1);
p.resume();
expect(processed).toBeFalsy();
expect(onText).toHaveBeenCalledTimes(1);
p.pause();
p.end("foo");
expect(processed).toBeFalsy();
expect(onText).toHaveBeenCalledTimes(1);
p.resume();
expect(processed).toBeTruthy();
expect(onText).toHaveBeenCalledTimes(2);
expect(onText).toHaveBeenLastCalledWith("foo");
});

test("should back out of numeric entities (#125)", () => {
let finished = false;
const onend = jest.fn();
let text = "";
const p = new Parser({
ontext(data) {
text += data;
},
onend() {
finished = true;
},
onend,
});

p.end("id=770&#anchor");

expect(finished).toBeTruthy();
expect(onend).toHaveBeenCalledTimes(1);
expect(text).toBe("id=770&#anchor");

p.reset();
text = "";
finished = false;

p.end("0&#xn");

expect(finished).toBeTruthy();
expect(onend).toHaveBeenCalledTimes(2);
expect(text).toBe("0&#xn");
});

Expand Down
Loading